Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Alpine base image version #484

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Bump Alpine base image version #484

merged 1 commit into from
Oct 2, 2018

Conversation

awly
Copy link
Contributor

@awly awly commented Sep 19, 2018

Alpine fixed a RCE vulnerability in apk in 3.8.1 (https://alpinelinux.org/posts/Alpine-3.8.1-released.html)
Update the base image used for ingress-gce.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2018
@awly
Copy link
Contributor Author

awly commented Sep 19, 2018

/assign @bowei

@awly
Copy link
Contributor Author

awly commented Oct 1, 2018

Ping @bowei

@bowei
Copy link
Member

bowei commented Oct 1, 2018

we can probably just use scratch and avoid the vulnerability stuff altogether?

@awly
Copy link
Contributor Author

awly commented Oct 1, 2018

That would be ideal, although it looks like ca-certificates are needed. I'm not aware of a vetted scratch+ca-certs image.
If it's easy to do, please send a separate PR and I'll close this one. Otherwise, we can do this quick patch and file an issue for switching to scratch.

@bowei
Copy link
Member

bowei commented Oct 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@bowei
Copy link
Member

bowei commented Oct 2, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awly, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bowei bowei merged commit fd31c7c into kubernetes:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants