Fix events-based e2e tests #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controller.go changes transformed ingress spec errors from Kubernetes Events to simple logs: https://github.com/kubernetes/ingress-gce/blob/master/pkg/controller/controller.go#L455 is returning. So we never hit https://github.com/kubernetes/ingress-gce/blob/master/pkg/controller/controller.go#L461 . As a consequence, some e2e tests, waiting for those events, bails out (ie. https://github.com/kubernetes/ingress-gce/blob/master/cmd/e2e-test/backend_config_test.go#L114 ). Notifying those errors as events -as they did previously- seems the proper course of action, and generaly useful beyond testing. Unrelated: end users may authenticate to GCP using OpenID Connect (at least I do); linking in client-go's plugin/pkg/client/auth/oidc allow them to run tests on their machines.
|
/lgtm |
|
/ok-to-test |
|
/lgtm |
k8s-ci-robot
added
lgtm
k8s-ci-robot
added
the
cncf-cla: yes
To match previous commits' Gopkg.lock changes.
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, bpineau, MrHohn, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller.go changes transformed ingress spec errors from Kubernetes Events to simple logs:
https://github.com/kubernetes/ingress-gce/blob/master/pkg/controller/controller.go#L455 is returning.
So we never hit https://github.com/kubernetes/ingress-gce/blob/master/pkg/controller/controller.go#L461 .
As a consequence, some e2e tests, waiting for those events, bails out
(ie. https://github.com/kubernetes/ingress-gce/blob/master/cmd/e2e-test/backend_config_test.go#L114 ).
Notifying those errors as events -as they did previously- seems the proper course of action,
and generaly useful beyond testing.
Unrelated: end users may authenticate to GCP using OpenID Connect (at least I do);
linking in client-go's plugin/pkg/client/auth/oidc allow them to run tests on their
machines.