Removing non code test's dependency on testing package #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
Closed
2 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
G-Harmon
added a commit
to G-Harmon/k8s-multicluster-ingress
that referenced
this pull request
Nov 16, 2017
I also had to clear my glide cache (~/.glide/cache) because I hit Masterminds/glide#592 . Do this to pick up Nikhil's change in ingress-gce to stop showing testing flags in kubemci -h (kubernetes/ingress-gce#69) Testing: Since this picks up a fair amount of new ingress-gce/ code (like NEGs support), I ran demo.sh and saw that the ingress works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing loadbalancer package's dependency on testing.
Without this change, any binary that depends on loadbalancer package also starts exposing test flags.
cc @nicksardo @bowei