Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for usability of GKE self managed setup script #759

Merged
merged 8 commits into from
Jun 4, 2019
Merged

Updates for usability of GKE self managed setup script #759

merged 8 commits into from
Jun 4, 2019

Commits on Jun 4, 2019

  1. Updated glbc arguments 

    - Removed arguments that no longer exist and those that are defaults.
- Updated command to not depend on sh (not available by default). Use
  same pattern as most GKE containers do.
- Image URL now ensures that the YAML would be invalid (more obvious if
  you miss it).
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    e4a5a59 View commit details
    Browse the repository at this point in the history

  2. Made gce.conf generated 

    All values are overridable in case the generation messes up.
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    b7b6b22 View commit details
    Browse the repository at this point in the history

  3. GKE self managed script now automated GLBC yaml 

    We build and push automatically if the user doesn't provide
--image-url.
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    b7576f2 View commit details
    Browse the repository at this point in the history

  4. No more winging it with time estimates 

    Better UX this way, too. Also more output about progress and
consistency in file names.
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    c64aaf9 View commit details
    Browse the repository at this point in the history

  5. Updated readme for new steps 

    Also fixed details on what the script does. It was confusing before
and had some order wrong.
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    672cd4f View commit details
    Browse the repository at this point in the history

  6. Addressed review changes 

    1. Restored confirmation for cluster being ready after disabling
   the default GLBC. Also made this affected by `--no-confirm`,
   since the intent of that was to allow non-interactive usage
   (cause forced interactive scripts are gross). Made that set
   `--quiet` for gcloud commands while I was at it, since some of
   those can confirm (and made it a versatile "provide arbitrary
   extra gcloud flags" thing). Only applied to mutating gcloud
   commands.
2. Build and push no longer implicit. As a result, either the
   `--image-url` or `--build-and-push` must be set. This is now
   validated.
3. Added validation for if CONTAINER_PREFIX is set while I was at
   it, since it can break build-and-push. I doubt anyone sets it,
   but better safe than sorry. This just avoids an inevitible error.
4. Placeholder used in GLBC YAML changed.
5. Using `.gen` as extension for generated files.
6. Make command is now logged so user sees what we're doing.
7. Clarified help text.
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    ccf623f View commit details
    Browse the repository at this point in the history

  7. Added --dry-run 

    This is very useful for testing. It uses kubectl --dry-run where
possible, so we're actually testing the structure of the YAML files
(the creation of the key does not use this since it depends on
running a real command).

This command can also be used to quickly and cleanly get the commands
this script would run for manual usage.

Fixed bug with --cleanup  where it would ignore any args after the
--cleanup tag (which could result in running the wrong things!).
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    94d4b30 View commit details
    Browse the repository at this point in the history

  8. Cleaner gce.conf + review changes 

    Also fixed dumb quote bug that wouldn't play nice with eval.
    @KatrinaHoffert
    KatrinaHoffert committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    147a374 View commit details
    Browse the repository at this point in the history