-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to override gce endpoint in test #761
Conversation
Welcome @krzyzacy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eeeeeeeeeeeeehhhh 😑need to manually append |
(don't need to touch https://github.com/kubernetes/ingress-gce/blob/master/cmd/e2e-test/run.sh#L38-L42 since it can be passed in as an arg)
/assign @MrHohn @rramkumar1