Add ListGlobalForwardingRules to the LoadBalancers interface. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
I see ListGlobalForwardingRules is implemented in GCECloud already: https://github.com/kubernetes/kubernetes/blob/6d32783453a6f624e9c0e2d818f58bdaa65199b3/pkg/cloudprovider/providers/gce/gce_forwardingrule.go#L73, so just adding it to the interface seems enough. lgtm, but will wait for @bowei or @nicksardo to take a look and lgtm and merge. |
I have an upcoming commit in the k8s-multicluster-ingress repo where I will use this.
G-Harmon
force-pushed
the
loadbalancerListRules
branch
from
ff0d766
to
6bb9414
Compare
|
I updated the Fake so that it actually returns the current firewall rules. (I ended up using this logic in my commit for kubemci, which I haven't sent out yet.) |
|
thx, still lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an upcoming commit in the k8s-multicluster-ingress repo where I will use this.
cc @bowei @nicksardo @nikhiljindal