Legacy api e2e #822
Merged
Legacy api e2e #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
rramkumar1
reviewed
Aug 11, 2019
pkg/e2e/legacy.go
Outdated
| } | ||
|
|
||
| func (crud *IngressCRUD) supportsNewAPI() (bool, error) { | ||
| apiList, err := crud.C.Discovery().ServerResourcesForGroupVersion("networking/v1beta1") |
There was a problem hiding this comment.
Do you need to return error? I don't see anything but nil returned.
cmd/e2e-test/draining_test.go
Outdated
| ing := fuzz.NewIngressBuilder("", "ingress-1", ""). | ||
| AddPath("test.com", "/", "service-1", intstr.FromInt(80)). | ||
| Build() | ||
| ing.Namespace = s.Namespace |
There was a problem hiding this comment.
Could you just set namespace in the builder? Same for other files too.
bowei
force-pushed
the
legacy-api-e2e
branch
2 times, most recently
from
c45afa0
to
786851b
Compare
IngressCRUD makes our e2e tests portable across older k8s API versions. e2e tests have been changed to use IngressCRUD.
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the e2e framework use an adapter so it can use both the old (extensions) and new (networking) APIs