Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for Finalizer #833

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Add e2e tests for Finalizer #833

merged 1 commit into from
Aug 28, 2019

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Aug 23, 2019

This adds the following e2e tests for Finalizer

  1. Ingress creation and deletion.
  2. Create Ingress, change Ingress class and delete Ingress.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 23, 2019
@skmatti
Copy link
Contributor Author

skmatti commented Aug 23, 2019

/assign mrhohn

@MrHohn
Copy link
Member

MrHohn commented Aug 23, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2019
MrHohn
MrHohn reviewed Aug 23, 2019
View reviewed changes
cmd/e2e-test/finalizer_test.go Outdated Show resolved Hide resolved
cmd/e2e-test/finalizer_test.go Outdated Show resolved Hide resolved
cmd/e2e-test/finalizer_test.go Outdated
if err != nil {
t.Fatalf("error waiting for Ingress to stabilize: %v", err)
}
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, ing.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: created

cmd/e2e-test/finalizer_test.go Outdated Show resolved Hide resolved
pkg/e2e/helpers.go Outdated Show resolved Hide resolved
cmd/e2e-test/finalizer_test.go Outdated Show resolved Hide resolved
MrHohn
MrHohn approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

cmd/e2e-test/finalizer_test.go
}
t.Logf("Finalizer for Ingress (%s/%s) deleted", s.Namespace, ing.Name)

if err := e2e.WaitForIngressDeletion(ctx, gclb, s, ing, deleteOptions); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: We might not need to wait for deletion one more time (WaitForFinalizerDeletion already does something similar)? The ingress object will be cleaned up along with the namespace deletion at the end by the test framework.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019
@MrHohn
Copy link
Member

MrHohn commented Aug 28, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@MrHohn
Copy link
Member

MrHohn commented Aug 28, 2019

Will hold a bit until we enable finalizer from in the test manifest.

@MrHohn
Copy link
Member

MrHohn commented Aug 28, 2019

Had some offline discussion with @skmatti, we think it is fine to let this in --- it will not run because of the testcase filter anyway.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit ee19757 into kubernetes:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@freehan freehan Awaiting requested review from freehan

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skmatti @k8s-ci-robot @MrHohn