Refactor ingress key function and finalizer into separate package

[skmatti]

Refactors some of ingress key utility functions and finalizer logic to a separate package so these can be accessed by namer package without import cycle. A subsequent PR #860 with utilization of these refactored functions inside namer package.

[k8s-ci-robot]

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skmatti]

/assign @MrHohn @freehan

[MrHohn]

/ok-to-test

[freehan]

How about we organize it this way:

KeyFunc is used only used to handle items in workqueue

After the initial process of ingress, everything is handled by IngressKeyFunc.

So you do not need the ToIngressKey function as middleman?

[skmatti]

The idea is to generate same key as that of Ingress Store and preserve backward compatibility. In theory, both KeyFunc and IngressKeyFunc should return same value with a valid Ingress. Some of the edge cases where they output different values is when namespace is empty. KeyFunc returns <name> where as IngressKeyFunc returns /<name>.

I changed the names a bit so they are less confusing and also added some description about why we need two separate functions as explained here.

[freehan]

ToString returns namespaced name string of a given ingress

[skmatti]

Done

[freehan]

LGTM

leave it for a 2nd pair of eyes.

[MrHohn]

/lgtm

[MrHohn]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MrHohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment