Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for frontend resource leak fix #905

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Add e2e tests for frontend resource leak fix #905

merged 1 commit into from
Nov 21, 2019

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Oct 21, 2019 •
edited
Loading

This adds tests for #894. This test asserts that frontend resources existence is in agreement with user specified ingress configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 21, 2019
@skmatti
Copy link
Contributor Author

skmatti commented Oct 21, 2019

/assign @freehan @MrHohn

@MrHohn
Copy link
Member

MrHohn commented Oct 21, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 13, 2019
@skmatti
Copy link
Contributor Author

skmatti commented Nov 13, 2019

/assign @rramkumar1

@skmatti skmatti force-pushed the resource-leak-fix-e2e branch 3 times, most recently from d4621cc to 408e216 Compare November 19, 2019 01:32
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2019
rramkumar1
rramkumar1 reviewed Nov 19, 2019
View reviewed changes
cmd/e2e-test/basic_test.go Outdated Show resolved Hide resolved
cmd/e2e-test/basic_test.go Show resolved Hide resolved
cmd/e2e-test/basic_test.go Outdated Show resolved Hide resolved
@skmatti skmatti force-pushed the resource-leak-fix-e2e branch 2 times, most recently from 58edc25 to 446cd6d Compare November 20, 2019 00:17
@skmatti skmatti mentioned this pull request Nov 20, 2019
Merged
MrHohn
MrHohn approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments.
/approve

cmd/e2e-test/basic_test.go Outdated Show resolved Hide resolved
pkg/fuzz/gcp.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
MrHohn
MrHohn approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 55f5179 into kubernetes:master Nov 21, 2019
@skmatti skmatti deleted the resource-leak-fix-e2e branch November 22, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@MrHohn MrHohn MrHohn approved these changes

@freehan freehan Awaiting requested review from freehan

Assignees

@freehan freehan

@MrHohn MrHohn

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skmatti @k8s-ci-robot @MrHohn @rramkumar1 @freehan