-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle cache.DeletedFinalStateUnknown #912
Handle cache.DeletedFinalStateUnknown #912
Conversation
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc: @bowei |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally learned where DeleteFinalStateUnknown
comes from :)
/approve
pkg/controller/controller.go
Outdated
if !ok { | ||
state, stateOk := obj.(cache.DeletedFinalStateUnknown) | ||
if !stateOk { | ||
klog.Errorf("wanted cache.DeleteFinalStateUnknown of backendconfig obj, got: %+v", obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Wanted...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pkg/controller/controller.go
Outdated
|
||
beConfig, beOk = state.Obj.(*backendconfigv1beta1.BackendConfig) | ||
if !beOk { | ||
klog.Errorf("wanted backendconfig obj, got %+v", state.Obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Wanted...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
var ok, beOk bool | ||
beConfig, ok = obj.(*backendconfigv1beta1.BackendConfig) | ||
if !ok { | ||
state, stateOk := obj.(cache.DeletedFinalStateUnknown) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put comment similar to https://github.com/kubernetes/client-go/blob/v12.0.0/tools/cache/controller.go#L173-L176 to explain what is going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…te event handlers
ab30143
to
566d92f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick #912 [Handle cache.DeletedFinalStateUnknown] to release-1.7
Handle cache.DeletedFinalStateUnknown in backend/frontend config delete event handlers
Currently, we just panic since the interface conversion fails.
/assign @MrHohn