-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update finalizer tests to validate against an ingress finalizer #956
Conversation
Hi @skmatti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@skmatti Can you update the description a bit to describe what exactly you are doing? To me it seems like you just created a couple helper functions and used them throughout the code but I would like to be sure of that. |
The v2-frontend-namer introduced a new finalizer (common.FinalizerKeyV2). Now there are two ingress finalizers after this change. But the finalizer tests were setup to validate only against old finalizer. This PR updates the tests so they expect one of the two ingress finalizers for validation. |
3d1ac40
to
0301fc1
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rramkumar1, skmatti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After adding new finalizer (V2 Finalizer), update finalizer upgrade tests to validate against either of v1 or v2 finalizers.