Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gce #98

Merged
merged 3 commits into from
Dec 29, 2017
Merged

Fix gce #98

merged 3 commits into from
Dec 29, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented Dec 28, 2017

New code requires direct import of the auth provider otherwise the auth provider plugin will no longer be registered.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 28, 2017
@bowei bowei requested a review from nicksardo December 28, 2017 23:40
@k8s-ci-robot
Copy link
Contributor

@bowei: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-gce-e2e 3c5e408 link /test pull-ingress-gce-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2017
@nicksardo nicksardo merged commit 157cda7 into kubernetes:master Dec 29, 2017
@bowei bowei deleted the fix-gce branch June 10, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants