Add e2e tests for NEG asm mode. #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/cc @freehan |
freehan
reviewed
Jan 9, 2020
freehan
reviewed
Jan 9, 2020
k8s-ci-robot
added
size/L
freehan
reviewed
Jan 15, 2020
| @@ -68,6 +70,15 @@ type WaitForIngressOptions struct { | |||
| ExpectUnreachable bool | |||
| } | |||
|
|
|||
| // Scheme is the default instance of runtime.Scheme to which types in the Kubernetes API are already registered. | |||
| // This is needed for ConfigMap search. | |||
| var Scheme = runtime.NewScheme() | |||
There was a problem hiding this comment.
can you give me a example?
freehan
reviewed
Jan 15, 2020
The e2e tests will test the configmap based asm mode on/off logic and the DestinationRule/Serivce NEG creation logic in the asm mode.
|
Commits squashed. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cadmuxe, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e tests will test the configmap based asm mode on/off logic and
the DestinationRule/Serivce NEG creation logic in the asm mode.