GLBC: Each ingress sync updates resources for all ingresses

[nicksardo]

For every ingress, the controller runs resource synchronization for all ingresses, thus resulting in unnecessary work.

Furthermore, if a GCP error occurs when handling one of the ingress resources, an event will be raised for every ingress resource.

[thockin]

What event?

[nicksardo]

A K8s Event record noting an error/warning message.

Take a look at this code: https://github.com/kubernetes/ingress/blob/7b38e5a36ed7e097e1cd98aca0f37c504059ab4c/controllers/gce/controller/controller.go#L311-L320
Checkpoint (https://github.com/kubernetes/ingress/blob/7b38e5a36ed7e097e1cd98aca0f37c504059ab4c/controllers/gce/controller/cluster_manager.go#L141-L149) creates/manages the resources for all ingresses. If there's an error, it's returned and an event is recorded for the ingress which caused the sync, but not necessarily the ingress which caused the error.

[thockin]

blech!

…

On Thu, Aug 3, 2017 at 10:10 AM, Nick Sardo ***@***.***> wrote: A K8s Event record noting an error/warning message. Take a look at this code: https://github.com/kubernetes/ingress/blob/ 7b38e5a/controllers/gce/ controller/controller.go#L311-L320 Checkpoint (https://github.com/kubernetes/ingress/blob/ 7b38e5a/controllers/gce/ controller/cluster_manager.go#L141-L149) creates/manages the resources for all ingresses. If there's an error, it's returned and an event is recorded for the ingress which caused the sync, but not necessarily the ingress which caused the error. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#950 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVMFWnIrMtJ0fE_9BSeJJIEw2IWOTks5sUf74gaJpZM4OU9aH> .

[bowei]

This issue was moved to kubernetes/ingress-gce#44