Create gcr.io/k8s-staging-build-image #288

javier-b-perez · 2019-07-03T23:16:00Z

Create an staging repository where to host the build image kube-cross.
This is part of #158

k8s-ci-robot · 2019-07-03T23:16:01Z

Welcome @javier-b-perez!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

dims · 2019-07-04T00:33:19Z

/approve
/lgtm
/hold

i'll run the script to create the google group and whoever can create the gcs bucket, please remove the hold and then run the script for creating the bucket.

k8s-ci-robot · 2019-07-04T00:33:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dims · 2019-07-04T00:36:04Z

DONE!

2019/07/03 20:35:29 Trying to create group: k8s-infra-staging-build-image@kubernetes.io
2019/07/03 20:35:30 > Successfully created group k8s-infra-staging-build-image@kubernetes.io
2019/07/03 20:35:31 > Successfully updated group settings for k8s-infra-staging-build-image@kubernetes.io to allow external members and other security settings
2019/07/03 20:35:32 Added davanum@gmail.com to k8s-infra-staging-build-image@kubernetes.io as a MEMBER
2019/07/03 20:35:33 Added jbperez@google.com to k8s-infra-staging-build-image@kubernetes.io as a MEMBER
2019/07/03 20:35:34 Added linusa@google.com to k8s-infra-staging-build-image@kubernetes.io as a MEMBER

thockin · 2019-07-08T16:01:31Z

Is this the right scope? Are there going to be other artifacts that this same group of people will need to administer?

javier-b-perez · 2019-07-08T16:50:50Z

Is this the right scope? Are there going to be other artifacts that this same group of people will need to administer?

the first item in mind is kube-cross, probably other images required to build, maybe even debian base images.
There might be others from the community as well that are interested in owning kube-cross.

thockin · 2019-07-08T16:52:48Z

Exactly what I was thinking. And you're happy with "build-image" as the umbrella repo for all these?

listx · 2019-07-08T17:05:41Z

Here are some alternate names for consideration:

"k8s-staging-prelude"
"k8s-staging-build-infra"

But I don't have strong opinions in this area because dims already created the resources and also I don't think we have an official policy on naming conventions anyway.

/lgtm

thockin · 2019-07-08T17:10:56Z

We don't have a convention here, and I don't think we need one. Just think forward to the things that will be in here. Will "build-image" be sufficiently descriptive that people won't be confused about its purpose? Maybe we should add a README in each dir explaining what the point of that repository is?

…

On Mon, Jul 8, 2019 at 10:05 AM Linus Arver ***@***.***> wrote: Here are some alternate names for consideration: "k8s-staging-prelude" "k8s-staging-build-infra" But I don't have strong opinions in this area because dims already created the resources and also I don't think we have an official policy on naming conventions anyway. /lgtm — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

dims · 2019-07-08T17:15:06Z

@listx let's do this ...
+1 to add a k8s.gcr.io/k8s-staging-build-image/README.md with some details.

javier-b-perez · 2019-07-09T00:48:31Z

Added README.md

listx · 2019-07-09T01:19:49Z

/lgtm

dims · 2019-07-09T01:29:55Z

@listx can you please remove hold and run the script to create the new bucket?

javier-b-perez · 2019-07-09T02:00:09Z

@thockin can you please create the bucket/project?

dims · 2019-07-09T10:35:37Z

i'll take care of this @javier-b-perez

dims · 2019-07-09T10:37:33Z

Created the ML

2019/07/09 06:37:00 > Successfully created group k8s-infra-staging-build-image@kubernetes.io
2019/07/09 06:37:01 > Successfully updated group settings for k8s-infra-staging-build-image@kubernetes.io to allow external members and other security settings
2019/07/09 06:37:02 Added davanum@gmail.com to k8s-infra-staging-build-image@kubernetes.io as a MEMBER
2019/07/09 06:37:03 Added jbperez@google.com to k8s-infra-staging-build-image@kubernetes.io as a MEMBER
2019/07/09 06:37:04 Added linusa@google.com to k8s-infra-staging-build-image@kubernetes.io as a MEMBER

dims · 2019-07-09T10:38:41Z

created the GCS bucket

[dims@dims-laptop 06:37] ~/go/src/k8s.io/k8s.io ⟩ ./infra/gcp/ensure-staging-storage.sh build-image
build-image
Ensuring project exists: k8s-staging-build-image
billingAccountName: billingAccounts/018801-93540E-22A20E
billingEnabled: true
name: projects/k8s-staging-build-image/billingInfo
projectId: k8s-staging-build-image
Enabling the container registry API
Ensuring the registry exists and is readable
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
Enabling Bucket Policy Only for gs://artifacts.k8s-staging-build-image.appspot.com...
Empowering GCR admins
Updated IAM policy for project [k8s-staging-build-image].
bindings:
- members:
  - serviceAccount:service-960211007710@containerregistry.iam.gserviceaccount.com
  role: roles/editor
- members:
  - user:davanum@gmail.com
  role: roles/owner
- members:
  - group:k8s-infra-artifact-admins@kubernetes.io
  role: roles/viewer
etag: BwWNPSchTgg=
version: 1
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
Empowering k8s-infra-staging-build-image@kubernetes.io to GCR
Enabling the GCS API
Operation "operations/acf.f5ff894a-543a-4e52-9bdb-3abe4c84160e" finished successfully.
Ensuring the bucket exists and is world readable
Creating gs://k8s-staging-build-image/...
Ensuring the bucket has retention of 30d
Setting Retention Policy on gs://k8s-staging-build-image/...
Ensuring the bucket has auto-deletion of 30 days
Setting lifecycle configuration on gs://k8s-staging-build-image/...
Empowering GCS admins
Updated IAM policy for project [k8s-staging-build-image].
bindings:
- members:
  - serviceAccount:service-960211007710@containerregistry.iam.gserviceaccount.com
  role: roles/editor
- members:
  - user:davanum@gmail.com
  role: roles/owner
- members:
  - group:k8s-infra-artifact-admins@kubernetes.io
  role: roles/viewer
etag: BwWNPShvEwA=
version: 1
Empowering k8s-infra-staging-build-image@kubernetes.io to GCS
Done

dims · 2019-07-09T10:38:50Z

/hold cancel

thockin

thockin@freakshow2 k8s.io master /infra/gcp$ ./ensure-staging-storage.sh build-image
build-image
Ensuring project exists: k8s-staging-build-image
billingAccountName: billingAccounts/018801-93540E-22A20E
billingEnabled: true
name: projects/k8s-staging-build-image/billingInfo
projectId: k8s-staging-build-image
Enabling the container registry API
Ensuring the registry exists and is readable
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
Enabling Bucket Policy Only for gs://artifacts.k8s-staging-build-image.appspot.com...
Empowering GCR admins
Updated IAM policy for project [k8s-staging-build-image].
bindings:
- members:
  - serviceAccount:service-960211007710@containerregistry.iam.gserviceaccount.com
  role: roles/editor
- members:
  - user:davanum@gmail.com
  role: roles/owner
- members:
  - group:k8s-infra-artifact-admins@kubernetes.io
  role: roles/viewer
etag: BwWNQTioEZc=
version: 1
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
Empowering k8s-infra-staging-build-image@kubernetes.io to GCR
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
No changes made to gs://artifacts.k8s-staging-build-image.appspot.com/
Enabling the GCS API
Ensuring the bucket exists and is world readable
No changes made to gs://k8s-staging-build-image/
Enabling Bucket Policy Only for gs://k8s-staging-build-image...
Ensuring the bucket has retention of 30d
Setting Retention Policy on gs://k8s-staging-build-image/...
Ensuring the bucket has auto-deletion of 30 days
Setting lifecycle configuration on gs://k8s-staging-build-image/...
Empowering GCS admins
Updated IAM policy for project [k8s-staging-build-image].
bindings:
- members:
  - serviceAccount:service-960211007710@containerregistry.iam.gserviceaccount.com
  role: roles/editor
- members:
  - user:davanum@gmail.com
  role: roles/owner
- members:
  - group:k8s-infra-artifact-admins@kubernetes.io
  role: roles/viewer
etag: BwWNQTlxZYM=
version: 1
No changes made to gs://k8s-staging-build-image/
No changes made to gs://k8s-staging-build-image/
Empowering k8s-infra-staging-build-image@kubernetes.io to GCS
No changes made to gs://k8s-staging-build-image/
No changes made to gs://k8s-staging-build-image/
Done

k8s-ci-robot assigned dims, justinsb and thockin Jul 3, 2019

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2019

k8s-ci-robot requested review from cblecker and dims July 3, 2019 23:16

k8s-ci-robot added the wg/k8s-infra label Jul 3, 2019

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 4, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019

k8s-ci-robot assigned listx Jul 8, 2019

javier-b-perez mentioned this pull request Jul 9, 2019

kube-cross makefile add REGISTRY kubernetes/kubernetes#79911

Merged

Create gcr.io/k8s-staging-build-image

518ec55

javier-b-perez force-pushed the build-image branch from 54e52da to 518ec55 Compare July 9, 2019 00:47

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2019

k8s-ci-robot merged commit b364ed6 into kubernetes:master Jul 9, 2019

thockin reviewed Jul 9, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create gcr.io/k8s-staging-build-image #288

Create gcr.io/k8s-staging-build-image #288

javier-b-perez commented Jul 3, 2019

k8s-ci-robot commented Jul 3, 2019

dims commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

dims commented Jul 4, 2019

thockin commented Jul 8, 2019

javier-b-perez commented Jul 8, 2019

thockin commented Jul 8, 2019

listx commented Jul 8, 2019

thockin commented Jul 8, 2019 via email

dims commented Jul 8, 2019

javier-b-perez commented Jul 9, 2019

listx commented Jul 9, 2019

dims commented Jul 9, 2019

javier-b-perez commented Jul 9, 2019

dims commented Jul 9, 2019

dims commented Jul 9, 2019

dims commented Jul 9, 2019

dims commented Jul 9, 2019

thockin left a comment

Create gcr.io/k8s-staging-build-image #288

Create gcr.io/k8s-staging-build-image #288

Conversation

javier-b-perez commented Jul 3, 2019

k8s-ci-robot commented Jul 3, 2019

dims commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

dims commented Jul 4, 2019

thockin commented Jul 8, 2019

javier-b-perez commented Jul 8, 2019

thockin commented Jul 8, 2019

listx commented Jul 8, 2019

thockin commented Jul 8, 2019 via email

dims commented Jul 8, 2019

javier-b-perez commented Jul 9, 2019

listx commented Jul 9, 2019

dims commented Jul 9, 2019

javier-b-perez commented Jul 9, 2019

dims commented Jul 9, 2019

dims commented Jul 9, 2019

dims commented Jul 9, 2019

dims commented Jul 9, 2019

thockin left a comment

Choose a reason for hiding this comment