Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup util/config packages; filenames and methods should be updated to use new names #1125

Closed
fabriziopandini opened this issue Sep 18, 2018 · 4 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@fabriziopandini
Copy link
Member

Package k8s.io/kubernetes/cmd/kubeadm/app/util/config/ contains a set of function for dealing with kubeadm config files.

Filenames and methods name should be now updated to use new names of the kubeadm config types. e.g.:
MasterConfiguration --> InitConfiguration
NodeConfiguration --> JoinConfiguration

@fabriziopandini fabriziopandini added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 18, 2018
@fabriziopandini fabriziopandini added this to the v1.13 milestone Sep 18, 2018
@fabriziopandini
Copy link
Member Author

/lifecycle active
/assign @RA489

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: GitHub didn't allow me to assign the following users: RA489.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/lifecycle active
/assign @RA489

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 20, 2018
@fabriziopandini fabriziopandini self-assigned this Sep 20, 2018
@RA489
Copy link
Contributor

RA489 commented Sep 20, 2018

@fabriziopandini I want to take this.

@fabriziopandini
Copy link
Member Author

@RA489 as agreed more detail on this issue. Feel free to add your ideas on top 😉

In v1.12 kubeadm config file (defined in the kubeadm/app/apis folder) transitioned from v1alpha2 to v1alpha3; this transition included also renaming of some types e.g.

v1alpha2.MasterConfiguration --> v1alpha3.InitConfiguration
v1alpha2.NodeConfiguration --> v1alpha3.JoinConfiguration

This issue aims to cleanup the codebase - file names and method names - from remaining references to old names (MasterConfiguration, NodeConfiguration), replacing them with new names (InitConfiguration, JoinConfiguration); please note that in the code base there are also yaml fragments that use old names; such yaml files SHOULD NOT be changed because they are used to test conversions of kubeadm config files written using old api versions.

File names that should be fixed are:

  • /kubeadm/app/util/config/masterconfig.go --> initconfiguration.go
  • /kubeadm/app/util/config/masterconfig_test.go --> initconfiguration_test.go
  • /kubeadm/app/util/config/nodeconfig.go --> joinconfiguration.go
  • /kubeadm/app/util/config/nodeconfig_test.go --> joinconfiguration_test.go

Method names that should be fixed are:

in /kubeadm/app/util/config/nodeconfig.go

  • NodeConfigFileAndDefaultsToInternalConfig -> JoinConfigFileAndDefaultsToInternalConfig

in /kubeadm/app/util/config/nodeconfig_test.go

  • TestNodeConfigFileAndDefaultsToInternalConfig -> TestJoinConfigFileAndDefaultsToInternalConfig

All references to the above methods should be fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants