Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kubeadm config print-defaults --api-objects {componentConfig} #1126

Closed
fabriziopandini opened this issue Sep 18, 2018 · 7 comments
Labels
area/UX good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@fabriziopandini
Copy link
Member

kubeadm config print-defaults command lets user to get a defaulted config file.

The command supports a --api-objects flag that allows to filter the api objects that will be included in the output. Currently value supported by this flag are only InitConfiguration, ClusterConfiguration and JoinConfiguration.

Since in v1.12 component config were moved out from ClusterConfiguration, now the --api-objects flag should be modified in order to accept also component config api objects: KubeletConfiguration and KubeProxyConfiguration

@fabriziopandini fabriziopandini added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. area/UX kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 18, 2018
@fabriziopandini fabriziopandini added this to the v1.13 milestone Sep 18, 2018
@Klaven
Copy link

Klaven commented Sep 18, 2018

I will take this issue.

@Klaven
Copy link

Klaven commented Sep 18, 2018

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 18, 2018
@Klaven
Copy link

Klaven commented Oct 1, 2018

@fabriziopandini Quick question, I saw some TODO's in the code that is related to this ticket. do you all want me to include the todo's in the PR?

An example of this would be found here: https://github.com/kubernetes/kubernetes/blob/e9a3aaa44b0655e0ca67be6d460a4ef0774e0648/cmd/kubeadm/app/cmd/config.go#L175

Anyhow. I'm still working on this, just wanted to know if you all would like me to clean up the TODO's that are in the code I'm working with.
thanks

@fabriziopandini
Copy link
Member Author

@Klaven
The two changes are un-related, even if impacting the same source file, so IMO it will be better to make a separated PR

@Klaven
Copy link

Klaven commented Oct 2, 2018

This ticket looks to be working on current master. @fabriziopandini can confirm. ticket should be closed.

@fabriziopandini
Copy link
Member Author

/close
many many thanks to @Klaven for help on investigating this ticket

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

/close
many many thanks to @Klaven for help on investigating this ticket

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UX good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants