Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should kubeadm check that ip_forward is turned on? #580

Closed
bboreham opened this issue Nov 29, 2017 · 7 comments · Fixed by kubernetes/kubernetes#63872
Closed

Should kubeadm check that ip_forward is turned on? #580

bboreham opened this issue Nov 29, 2017 · 7 comments · Fixed by kubernetes/kubernetes#63872
Assignees
@kad
Labels
area/UX priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.11

Comments

@bboreham
Copy link

FEATURE REQUEST

I came across someone whose kubeadm-created cluster was somewhat broken because IP forwarding was turned off. I believe it's mandatory for Kubernetes; for example this guide says it has to be on.

Enable ipv4 forwarding sysctl, net.ipv4.ip_forward = 1

So, should this be added to the preflight checks?
@sathieu
Copy link

sathieu commented Dec 14, 2017

Related to kubernetes/kubernetes#40182? (fixed by kubernetes/kubernetes#52569 in 1.9)

@bboreham
Copy link
Author

The systctl is distinct from the iptables setting which is what that PR targets; both have to be on for Kubernetes to work.

@sathieu
Copy link

sathieu commented Dec 15, 2017

But docker sets ip_forward. You're talking about other CRI?

@kad
Copy link
Member

kad commented Dec 15, 2017

beside ipv4 there is also ipv6 forwarding and also question, should it be enabled for all interfaces or not ?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2018
@timothysc
Copy link
Member

/assign @kad

@timothysc timothysc added this to the v1.11 milestone Apr 7, 2018
@timothysc timothysc added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 7, 2018
@timothysc
Copy link
Member

@kad could you verify that this is all fixed now?

@luxas luxas modified the milestones: v1.11, v1.12 May 15, 2018
@kad kad mentioned this issue May 15, 2018
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 16, 2018
@kad
kubeadm preflight check for IPv4 and IPv6 forwarding
510ce3c 
Fixes: kubernetes/kubeadm#580
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue May 16, 2018
Merge pull request #63872 from kad/ipforward
6f286db 
Automatic merge from submit-queue (batch tested with PRs 63589, 63644, 63861, 63872, 63847). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubeadm preflight check for IPv4 and IPv6 forwarding

**What this PR does / why we need it**: adds preflight check for IP forwarding

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes/kubeadm#580

**Special notes for your reviewer**:

**Release note**:
```release-note
kubeadm now checks that IPv4/IPv6 forwarding is enabled
```
vikaschoudhary16 pushed a commit to vikaschoudhary16/kubernetes that referenced this issue May 18, 2018
@kad @vikaschoudhary16
kubeadm preflight check for IPv4 and IPv6 forwarding
b3c54e6 
Fixes: kubernetes/kubeadm#580
@luxas luxas modified the milestones: v1.12, v1.11 May 20, 2018
@luxas luxas added kind/enhancement area/UX priority/backlog Higher priority than priority/awaiting-more-evidence. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels May 20, 2018
wenjiaswe pushed a commit to wenjiaswe/kubernetes that referenced this issue Jun 19, 2018
@kad @wenjiaswe
kubeadm preflight check for IPv4 and IPv6 forwarding
35513e1 
Fixes: kubernetes/kubeadm#580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kad kad

Labels
area/UX priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

kubeadm preflight check for IPv4 and IPv6 forwarding kad/kubernetes
7 participants
@kad @timothysc @sathieu @luxas @bboreham @k8s-ci-robot @fejta-bot