Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRD watch does not work with protobuf encoding #55541

Closed
justinsb opened this issue Nov 12, 2017 · 10 comments
Closed

CRD watch does not work with protobuf encoding #55541

justinsb opened this issue Nov 12, 2017 · 10 comments
Labels
area/custom-resources kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@justinsb
Copy link
Member

When a CRD clientset is built with ContentType = "application/vnd.kubernetes.protobuf", CRD watch is not notified of updates.

I think this was root cause of my suspicion around CRD watch being broken (#55538)
@justinsb
Copy link
Member Author

@kubernetes/sig-api-machinery-bugs

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/bug Categorizes issue or PR as related to a bug. labels Nov 12, 2017
justinsb added a commit to justinsb/scaler that referenced this issue Nov 12, 2017
@justinsb
Turn off protobuf for CRD
1479994 
Breaks all watches -
kubernetes/kubernetes#55541
@lavalamp
Copy link
Member

@enisoc

I'm very surprised you can do proto with CRDs? How does the system interact with the metadata?

@yliaog
Copy link
Contributor

yliaog commented Nov 13, 2017

/cc @yliaog

@ncdc
Copy link
Member

ncdc commented Nov 13, 2017

@lavalamp you can't. CRDs only support JSON.

@enisoc
Copy link
Member

enisoc commented Nov 13, 2017

As @ncdc said, CRD only supports JSON, for the reason @lavalamp alluded to. We allow the custom objects to be effectively schemaless, so there's no source of truth from which to generate protobuf definitions.

@nikhita
Copy link
Member

nikhita commented Nov 23, 2017

/area custom-resources

@liggitt
Copy link
Member

liggitt commented Jan 15, 2018

When I try to establish a watch requesting proto content, I get a 415 error as expected. Are you seeing something different?

@nikhita
Copy link
Member

nikhita commented Jan 23, 2018

ping @justinsb ^

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2018
@nikhita
Copy link
Member

nikhita commented May 10, 2018

I guess we can close this?

@sttts sttts closed this as completed May 10, 2018
@ashish-amarnath ashish-amarnath mentioned this issue Jan 21, 2020
Closed
@skmatti skmatti mentioned this issue Mar 11, 2020
Closed
Merged
@Fei-Guo Fei-Guo mentioned this issue Mar 3, 2021
Closed
@qicz qicz mentioned this issue Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/custom-resources kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@ncdc @justinsb @lavalamp @sttts @liggitt @enisoc @nikhita @k8s-ci-robot @fejta-bot @yliaog