Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should fix typos like limitting #71683

Closed
danielqsj opened this issue Dec 4, 2018 · 4 comments · Fixed by #71684
Closed

Should fix typos like limitting #71683

danielqsj opened this issue Dec 4, 2018 · 4 comments · Fixed by #71684
Assignees
@danielqsj
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@danielqsj
Copy link
Contributor

danielqsj commented Dec 4, 2018 •
edited
Loading

What happened:
There are some files and comments using limitting and limitted, but these words are typos.

What you expected to happen:
Should rename them with limiting and limited.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): master branch
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

/kind bug
/sig cli
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 4, 2018
@danielqsj
Copy link
Contributor Author

/assign

This was referenced Dec 4, 2018
Merged
Merged
@nikhita
Copy link
Member

nikhita commented Dec 4, 2018

/remove-kind bug
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 4, 2018
@yue9944882
Copy link
Member

no need for a dedicated issue for typos, just take it please

/close

@k8s-ci-robot
Copy link
Contributor

@yue9944882: Closing this issue.

In response to this:

no need for a dedicated issue for typos, just take it please

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielqsj danielqsj

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typos like limitting danielqsj/kubernetes
4 participants
@danielqsj @yue9944882 @nikhita @k8s-ci-robot