-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump namespace if the namespace could not be cleaned up #85542
Conversation
Hi @schrodit. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig testing |
/assign @timothysc |
@oomichi any update on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: schrodit, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
The e2e testsuite performs a cleanup after each tests were namespaces are deleted.
If this cleanup fails the only thing that is currently logged is the client-go error which is most of the time not helpful as namespace deletion can be blocked by various resources that are still left/cannot be cleaned up.
If the tests are even executed successfully we do not get the namespace dump (
DumpAllNamespaceInfo
) which is very helpful when debugging such issues.This PR adds the namespace dump even if all tests succeeded but the cleanup fails.
Example bug where test succeeded but the namespace cannot be deleted as of a stuck pod: #85541
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: