Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release notes yaml lint errors #2446

Merged

Conversation

npolshakova
Copy link
Contributor

What type of PR is this:

/kind cleanup

What this PR does / why we need it:

The misformatted yaml release notes merged into sig-release are blocking the krel command from running for v1.30.0-alpha.3:

Press enter to start (1/10)

INFO + /usr/bin/git config --get user.email        file="command/command.go:326"
INFO + /usr/bin/git config --get user.name         file="command/command.go:326"
DEBU Reading session data from maps-1706895622.json  file="cmd/release_notes.go:1035"
DEBU Reading session data from maps-1708071507.json  file="cmd/release_notes.go:1035"
INFO Read 245 PR reviews from previous sessions    file="cmd/release_notes.go:1052"

Welcome to the Kubernetes Release Notes editing tool!

This tool will allow you to review and edit all the release
notes submitted by the Kubernetes contributors before publishing
the updated draft.

The flow will show each of the release notes that need to be
reviewed once and you can choose to edit it or not.

After you choose, it will be marked as reviewed and will not
be shown during the next sessions unless you choose to do a
full review of all notes.

You can hit Ctrl+C at any time to exit the review process
and submit the draft PR with the revisions made so far.

Would you like to continue from the last session? (Y/n) (1/10)
Y

Release Note for PR 121461:
===========================
Pull Request URL: https://github.com/kubernetes/kubernetes/pull/121461
FATA creating Draft PR: while running release notes fix flow: while getting map for PR #121461: while reading release notes maps: while parsing note map in /var/folders/7t/273pt80d51l70mj4rxznq_lm0000gn/T/k8s-518856267/releases/release-1.30/release-notes/maps/pr-119177-map.yaml: decoding note map: yaml: line 5: did not find expected key  file="cmd/root.go:61"

Slack thread: https://kubernetes.slack.com/archives/CN1KH4K9A/p1709327978866689

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-team Issues or PRs related to the release-team subproject labels Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2024
@puerco
Copy link
Member

puerco commented Mar 6, 2024

Thanks for fixeing these @npolshakova ! Was this because of a bug?
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npolshakova, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 06c63aa into kubernetes:master Mar 6, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 6, 2024
@ramrodo
Copy link
Member

ramrodo commented Mar 6, 2024

Thanks for fixeing these @npolshakova ! Was this because of a bug? /lgtm /approve

Hi @puerco, right, some of these missing typos/fixes from the bug are described here: kubernetes/release#2753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants