Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release notes draft to version v1.31.0-beta.0 #2575

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Update release notes draft to version v1.31.0-beta.0 #2575

merged 1 commit into from
Jul 30, 2024

Conversation

cloudmelon
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.31.0-beta.0

Which issue(s) this PR fixes:

Special notes for your reviewer:
This is an automated PR generated from krel The Kubernetes Release Toolbox

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/release-team Issues or PRs related to the release-team subproject labels Jul 23, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 23, 2024
npolshakova
npolshakova reviewed Jul 24, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-124320-map.yaml Outdated
@@ -0,0 +1,23 @@
pr: 124320
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete this map file- it's a known krel bug: kubernetes/release#3516

npolshakova
npolshakova reviewed Jul 24, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-124994-map.yaml Outdated
@@ -0,0 +1,4 @@
pr: 124994
releasenote:
text: Added namespace autocompletion for kubectl config set-context command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text: Added namespace autocompletion for kubectl config set-context command
text: Added namespace autocompletion for `kubectl config set-context` command.

shecodesmagic
shecodesmagic reviewed Jul 24, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-123587-map.yaml
@@ -1,3 +1,4 @@
pr: 123587
releasenote:
text: Fixed "-kube-test-repo-list" e2e flag may not take effect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the first "-" in "-kube-test-repo-list" a typo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what the author originally had: kubernetes/kubernetes#123587

shecodesmagic
shecodesmagic reviewed Jul 24, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-123638-map.yaml
@@ -1,4 +1,5 @@
pr: 123638
releasenote:
text: Graduated MatchLabelKeys/MismatchLabelKeys feature in PodAffinity/PodAntiAffinity to Beta.
text: Graduated MatchLabelKeys/MismatchLabelKeys feature in PodAffinity/PodAntiAffinity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
text: Graduated MatchLabelKeys/MismatchLabelKeys feature in PodAffinity/PodAntiAffinity
text: Graduated MatchLabelKeys/MismatchLabelKeys feature in PodAffinity/PodAntiAffinity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is wrong, no need to update here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

npolshakova
npolshakova reviewed Jul 24, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-125365-map.yaml Outdated
@@ -0,0 +1,23 @@
pr: 125365
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete this map file- it's a known krel bug: kubernetes/release#3516

npolshakova
npolshakova reviewed Jul 26, 2024
View reviewed changes
releases/release-1.31/release-notes/release-notes-draft.json Outdated
@@ -250,13 +262,12 @@
"sigs": [
"cli"
],
"duplicate_kind": true,
"is_mapped": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example of is_mapped value.

npolshakova
npolshakova reviewed Jul 26, 2024
View reviewed changes
releases/release-1.31/release-notes/release-notes-draft.json
@@ -34,13 +33,12 @@
"cli",
"windows"
],
"duplicate": true,
"is_mapped": true
Copy link
Contributor

@npolshakova npolshakova Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed, you want to go back in this diff commit and add the is_mapped": true values back.

npolshakova
npolshakova reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@npolshakova npolshakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple last comments to resolve and this should be good to go!

@cloudmelon
Copy link
Contributor Author

Looks good! Just a couple last comments to resolve and this should be good to go!

great news ! Let me doublecheck everything and squash them into 1 big fat commit !

@cloudmelon @npolshakova @shecodesmagic
Update releases/release-1.31/release-notes/maps/pr-122025-map.yaml
ef1d492 
update upon the convention

Update releases/release-1.31/release-notes/maps/pr-126012-map.yaml

Update upon convention ponctuation and past times

Update release note release-notes-draft-v1.31.0-beta.0

release notes draft release-notes-draft-v1.31.0-beta.0

add map values

change draft json and md

Delete releases/release-1.31/release-notes/maps/pr-125365-map.yaml

Delete this file due to a known bug kubernetes/release#3516

Update releases/release-1.31/release-notes/maps/pr-125894-map.yaml

Update releases/release-1.31/release-notes/maps/pr-125970-map.yaml

Update releases/release-1.31/release-notes/maps/pr-126046-map.yaml

Update releases/release-1.31/release-notes/maps/pr-126057-map.yaml

Update releases/release-1.31/release-notes/maps/pr-126012-map.yaml

Update releases/release-1.31/release-notes/maps/pr-125328-map.yaml

Update releases/release-1.31/release-notes/maps/pr-124994-map.yaml

Update releases/release-1.31/release-notes/maps/pr-122025-map.yaml

Update releases/release-1.31/release-notes/maps/pr-125751-map.yaml

Update releases/release-1.31/release-notes/maps/pr-125442-map.yaml

Update releases/release-1.31/release-notes/maps/pr-125333-map.yaml

Update releases/release-1.31/release-notes/maps/pr-125225-map.yaml

Update releases/release-1.31/release-notes/maps/pr-124994-map.yaml

Update releases/release-1.31/release-notes/maps/pr-124428-map.yaml

sure

Delete releases/release-1.31/release-notes/maps/pr-124320-map.yaml

Release Notes draft for k/k v1.31.0-beta.0

Signed-off-by: cloudmelon <akacloudmelon@gmail.com>
Co-Authored-By: Nina Polshakova <nina.polshakova@solo.io>
Co-Authored-By: Sepideh <sepi.alavii@gmail.com>
@cloudmelon cloudmelon force-pushed the release-notes-draft-v1.31.0-beta.0 branch from 06a8f9b to ef1d492 Compare July 29, 2024 19:23
npolshakova
npolshakova approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@npolshakova npolshakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of all the edits and squashing them into one commit @cloudmelon 🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cloudmelon, npolshakova, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3c49dad into kubernetes:master Jul 30, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shecodesmagic shecodesmagic shecodesmagic left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@npolshakova npolshakova npolshakova approved these changes

@Princesso Princesso Awaiting requested review from Princesso

Assignees

@saschagrunert saschagrunert

@npolshakova npolshakova

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@cloudmelon @k8s-ci-robot @saschagrunert @npolshakova @shecodesmagic