Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update Prow to v20230328-2d2bbbf73b" #29167

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Revert "Update Prow to v20230328-2d2bbbf73b" #29167

merged 1 commit into from
Mar 28, 2023

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Mar 28, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2023
@ameukam
Copy link
Member

ameukam commented Mar 28, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. area/config Issues or PRs related to code in /config labels Mar 28, 2023
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync labels Mar 28, 2023
eddiezane
eddiezane approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder, eddiezane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

BenTheElder commented Mar 28, 2023 •
edited
Loading

/skip
[skip optional tests]

@BenTheElder
Copy link
Member Author

/override pull-test-infra-integration

too slow and we're reverting back to a known-good state, not a blocking /required job but I keep forgetting /skip only works when a job finishes, so manually overriding the job that would be skipped later anyhow.

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-test-infra-integration

In response to this:

/override pull-test-infra-integration

too slow and we're reverting back to a known-good state, not a blocking /required job but I keep forgetting /skip only works when a job finishes, so manually overriding the job that would be skipped later anyhow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@puerco puerco mentioned this pull request Mar 28, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 0fbd144 into master Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key sig-contribex-k8s-triage-robot.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml
    • key sig-k8s-infra-prow.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-prow.yaml
    • key sig-k8s-infra-test-infra.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-test-infra.yaml
    • key test-infra-presubmits.yaml using file config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml
    • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
  • config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml

In response to this:

Reverts #29166

CI is very broken https://kubernetes.slack.com/archives/C7J9RP96G/p1680020553428789

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the revert-29166-autobump branch March 28, 2023 16:43
@ConnorJC3 ConnorJC3 mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane approved these changes

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

Assignees

@eddiezane eddiezane

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @ameukam @k8s-ci-robot @eddiezane