Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4033: cgroup driver from CRI beta blog #47054

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

haircommander
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jul 1, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 1, 2024
@haircommander haircommander changed the base branch from main to dev-1.31 July 1, 2024 17:03
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0bc5734
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66c3af6e1aeb9100086050aa
😎 Deploy Preview https://deploy-preview-47054--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@a-mccarthy
Copy link
Contributor

Hi @haircommander thanks for your interest in contributing a blog for 1.31. Please update this to target the main branch instead of dev-1.31.

/hold

Pending assignment of publication date (by release comms)

We'll also keep this held until the v1.31 release has happened

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2024
@rashansmith
Copy link

Hello! I'm Rashan, from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help!

@a-mccarthy
Copy link
Contributor

Hello @haircommander today is our ready for review deadline for blog content for 1.31. Are you still interested in writing a blog for this feature?

If so please let us know. This blog publication is scheduled for August 21. and this PR should target the main branch instead of dev-1.31.

cc: @rashansmith

@haircommander haircommander changed the base branch from dev-1.31 to main July 26, 2024 16:37
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2024
@rashansmith
Copy link

Hello @haircommander,

Is your blog ready for review?

If so, please let us know.

cc: @a-mccarthy

@haircommander haircommander changed the title 4033 beta blog KEP-4033: cgroup driver from CRI beta blog Jul 30, 2024
@haircommander haircommander marked this pull request as ready for review July 30, 2024 13:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@haircommander
Copy link
Contributor Author

yes this is ready!

@kannon92
Copy link
Contributor

kannon92 commented Aug 5, 2024

/hold cancel

layout: blog
title: "Configuring Kubernetes just got easier: cgroup driver from CRI"
date: 2024-07-01
slug: cgroup driver from CRI to betra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Suggested change
slug: cgroup driver from CRI to betra
slug: cgroup driver from CRI to beta

@haircommander
Copy link
Contributor Author

thanks @divya-mohan0209 updated

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here's a second batch of comments. WDYT?

Would appreciate a second pair of eyes on this one and shall socialise on the sig docs blog channel.

---
layout: blog
title: "Configuring Kubernetes just got easier: cgroup driver from CRI"
date: 2024-08-06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-mccarthy : Is this the correct date for publication? If not, please could you confirm what this needs to be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the filename, I'm guessing it should be 2024-08-21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #47054 (comment)

Suggested change
date: 2024-08-06
date: 2024-08-21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still hasn't been resolved in the commit visible to me. Please can we update it to the latest date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## `KubeletCgroupDriverFromCRI` Feature Gate

In v1.28.0, the SIG Node community introduced the feature gate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In v1.28.0, the SIG Node community introduced the feature gate
In v1.28.0, the SIG Node community introduced the [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)

feature is now beta!

In addition to setting the feature gate, a cluster admin needs to ensure their
CRI implementatikn is new enough:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current statement is likely to confuse users, as they might think they need to be on the latest version of the CRI for this to work. From the information given below, it would make more sense to say supported instead of new enough.

Suggested change
CRI implementatikn is new enough:
CRI implementation is new enough:

@mbianchidev
Copy link
Member

Thanks! Here's a second batch of comments. WDYT?

Would appreciate a second pair of eyes on this one and shall socialise on the sig docs blog channel.

I think that excluding your comments (I think they should be incorporated) it looks good!

@@ -0,0 +1,38 @@
---
layout: blog
title: "Configuring Kubernetes just got easier: cgroup driver from CRI"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this needs to follow title casing per our style guide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Configuring Kubernetes just got easier: cgroup driver from CRI"
title: "Kubernetes v1.31: Autoconfiguration For Node Cgroup Driver (beta)"

@sftim
Copy link
Contributor

sftim commented Aug 14, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More feedback

layout: blog
title: "Configuring Kubernetes just got easier: cgroup driver from CRI"
date: 2024-08-21
slug: cgroup driver from CRI to beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
slug: cgroup driver from CRI to beta
slug: cri-cgroup-driver-lookup-now-beta

the same cgroup driver, or else the kubelet would exit with an error. This was a
source of headaches for many cluster admins. However, there is light at the end of the tunnel!

## `KubeletCgroupDriverFromCRI` Feature Gate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## `KubeletCgroupDriverFromCRI` Feature Gate
## Automated CRI driver configuration

or, less ideal

Suggested change
## `KubeletCgroupDriverFromCRI` Feature Gate
## `KubeletCgroupDriverFromCRI` feature gate

Then, they should ensure their CRI implementation is configured to the
`cgroup_driver` they would like to use.

## Future Work
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Future Work
## Future work

Comment on lines 28 to 29
- containerd: Support has been added in v2.0.0
- CRI-O: Support has been added in v1.28.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- containerd: Support has been added in v2.0.0
- CRI-O: Support has been added in v1.28.0
- containerd: Support was added in v2.0.0
- CRI-O: Support was added in v1.28.0

@@ -0,0 +1,38 @@
---
layout: blog
title: "Configuring Kubernetes just got easier: cgroup driver from CRI"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Configuring Kubernetes just got easier: cgroup driver from CRI"
title: "Kubernetes v1.31: Autoconfiguration For Node Cgroup Driver (beta)"

@haircommander
Copy link
Contributor Author

updated thanks!

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3033422e01cc20ed4528525b99bd21a7600e5074

@sftim
Copy link
Contributor

sftim commented Aug 20, 2024

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit d1c85f9 into kubernetes:main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

8 participants