Fix reserved keyword escape example in CEL #47382
Conversation
Add the missing escaped property name for the reserved keywords example in the CEL escape sequences examples table.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| | `namespace` | `self.__namespace__ > 0` | | ||
| | `x-prop` | `self.x__dash__prop > 0` | | ||
| | `redact__d` | `self.redact__underscores__d > 0` | | ||
| | `string` | `self.__{string}__.startsWith('kube')` | |
There was a problem hiding this comment.
We don't escape string as field name. I don't understand this change..
There was a problem hiding this comment.
But I believe it is what was meant to be done in the first place. An example on how to escape reserved keywords...
The current example doesn't really make sense, does-it ?
There was a problem hiding this comment.
How about dropping the line:
| `string` | `self.startsWith('kube')` |entirely?
There was a problem hiding this comment.
I believe this would be a shame as an example makes it clear how reserved keywords should be escaped.
Could we get feedback from someone who knows how CEL escape sequences work and make sure the example is correct?
There was a problem hiding this comment.
@cici37 knows a thing or two!
There was a problem hiding this comment.
I'm in favor of having tests in code that match all examples given here. That way if there is any disagreement about how the system behaves, we have direct evidence of what the actual behavior is.
|
@kubernetes/sig-api-machinery-pr-reviews please take a look |
k8s-ci-robot
added
the
sig/api-machinery
Description
Add the missing escaped property name for the reserved keywords example in the CEL escape sequences examples table.