-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[virt-operator]: fix kubevirt version parsing #9564
[virt-operator]: fix kubevirt version parsing #9564
Conversation
/cc @acardace |
there was an issue when virt-operator image had digest instead of a tag, the hardcoded "latest" tag was used and KUBEVIRT_VERSION was ignored. this commit fixes this issue by taking the Kubevirt version from the KUBEVIRT_VERSION env var in case digest is used instead of tag. Signed-off-by: enp0s3 <ibezukh@redhat.com>
0190fd7
to
f4a4fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@dhiller the PR was rebased to resolve a merge conflict, PTAL!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.59 |
@jean-edouard: once the present PR merges, I will cherry-pick it on top of release-0.59 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest-required |
/retest-required |
@enp0s3: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jean-edouard: #9564 failed to apply on top of branch "release-0.59":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: enp0s3 ibezukh@redhat.com
When the virt-operator image has digest instead of a tag, parse kubevirt version from KUBEVIRT_VERSION environment variable.
What this PR does / why we need it:
there was an issue when virt-operator image had digest instead of a tag, the hardcoded "latest" tag was used and KUBEVIRT_VERSION was ignored.
This led to an issue with tracking the kubevirt upgrade process. Periodic comparison of the KUBEVIRT_VERSION with the
status.observedKubevirtVersion
failed because the latter field got thelatest
string, instead of having the version as defined in KUBEVIRT_VERSION.Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2180146
Release note: