-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.1 #49
Release v0.5.1 #49
Conversation
Skipping CI for Draft Pull Request. |
/release-note-none |
Signed-off-by: Or Shoval <oshoval@redhat.com>
Amm.. Why are we issuing a patch release and not a minor one? |
And sometimes there's major.
? It would be the bot building images and pushing them to quay. You don't need credentials. Depends on the change; bumping the dependency is clearly material for a patch release; I guess it depends on what exactly is the change you pushed. Is that a new functionality ?... Is a bugfix ?... I personally don't think it is new functionality, but let's hear @RamLavi out. |
Indeed not new functionality imho, #48 |
Following what you said I tend to agree, Let's keep this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maiqueb, oshoval, RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Features:
Signed-off-by: Or Shoval oshoval@redhat.com