Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.1 #49

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Release v0.5.1 #49

merged 1 commit into from
Jul 14, 2021

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Jul 14, 2021

Features:

  • install-cni, Add resources requests for initContainer
  • dependencies: use containernetworking/plugins v0.9.1

Signed-off-by: Or Shoval oshoval@redhat.com

@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2021
@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jul 14, 2021
@oshoval
Copy link
Contributor Author

oshoval commented Jul 14, 2021

/release-note-none

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2021
version/description Outdated Show resolved Hide resolved
Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval oshoval marked this pull request as ready for review July 14, 2021 08:23
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2021
@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@RamLavi
Copy link
Contributor

RamLavi commented Jul 14, 2021

Amm.. Why are we issuing a patch release and not a minor one?

@oshoval
Copy link
Contributor Author

oshoval commented Jul 14, 2021

Amm.. Why are we issuing a patch release and not a minor one?

interesting,
i see sometimes there is patch and sometimes there is minor
anyhow make minor i can't do myself because it also pushes to quay and i don't have credentials i think

@maiqueb @phoracek
should we create a minor or patch ?

@maiqueb
Copy link
Collaborator

maiqueb commented Jul 14, 2021

Amm.. Why are we issuing a patch release and not a minor one?

interesting,
i see sometimes there is patch and sometimes there is minor

And sometimes there's major.

anyhow make minor i can't do myself because it also pushes to quay and i don't have credentials i think

? It would be the bot building images and pushing them to quay. You don't need credentials.

@maiqueb @phoracek
should we create a minor or patch ?

Depends on the change; bumping the dependency is clearly material for a patch release; I guess it depends on what exactly is the change you pushed. Is that a new functionality ?... Is a bugfix ?...

I personally don't think it is new functionality, but let's hear @RamLavi out.

@oshoval
Copy link
Contributor Author

oshoval commented Jul 14, 2021

Depends on the change; bumping the dependency is clearly material for a patch release; I guess it depends on what exactly is the change you pushed. Is that a new functionality ?... Is a bugfix ?...

I personally don't think it is new functionality, but let's hear @RamLavi out.

Indeed not new functionality imho, #48
just add minimum requests for the initContainer

@RamLavi
Copy link
Contributor

RamLavi commented Jul 14, 2021

Depends on the change; bumping the dependency is clearly material for a patch release; I guess it depends on what exactly is the change you pushed. Is that a new functionality ?... Is a bugfix ?...
I personally don't think it is new functionality, but let's hear @RamLavi out.

Indeed not new functionality imho, #48
just add minimum requests for the initContainer

Following what you said I tend to agree, Let's keep this.

Copy link
Contributor

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb, oshoval, RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 69046c3 into kubevirt:main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants