Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

パッケージの情報が古いため、create-lint-set が動作しなくなっている問題を修正 #409

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

f440
Copy link
Member

@f440 f440 commented Jul 28, 2024

npx @smarthr/create-lint-set を実行するとエラーとなります。

% npx @smarthr/create-lint-set
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: xxx@1.0.0
npm error Found: stylelint@14.16.1
npm error node_modules/stylelint
npm error   dev stylelint@"*" from the root project
npm error   peer stylelint@">= 11.x < 15" from stylelint-config-prettier@9.0.5
npm error   node_modules/stylelint-config-prettier
npm error     dev stylelint-config-prettier@"*" from the root project
npm error
npm error Could not resolve dependency:
npm error dev stylelint-config-smarthr@"*" from the root project
npm error
npm error Conflicting peer dependency: stylelint@16.7.0
npm error node_modules/stylelint
npm error   peer stylelint@"^16.0.0" from stylelint-config-smarthr@3.0.1
npm error   node_modules/stylelint-config-smarthr
npm error     dev stylelint-config-smarthr@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

確認したところ、パッケージの組み合わせが古いようです。(参考: kufu/stylelint-config-smarthr#205

動作するよう対象のパッケージ一覧を修正しました。

@f440 f440 requested a review from a team as a code owner July 28, 2024 14:33
@f440 f440 requested review from nabeliwo and Tokky0425 and removed request for a team July 28, 2024 14:33
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝 🙏

@Tokky0425 Tokky0425 merged commit 2328837 into kufu:master Jul 29, 2024
3 checks passed
@f440 f440 deleted the update-packages-in-create-lint-set branch July 29, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants