Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample using Datalabels plugin #107

Merged
merged 2 commits into from
Sep 18, 2022
Merged

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented Sep 17, 2022

Fix #75

EDIT: sets karma-rollup-preprocessor to version 7.0.7 to avoid usual bugs on that.

@stockiNail
Copy link
Collaborator Author

@kurkle tought: due to the datalabels plugin sounds working with treemap controller, do you think it still makes sense to have labels and captions capabilities in the controller? Maybe they could be delegated to data-labels.

@stockiNail stockiNail added this to the 2.1.0 milestone Sep 17, 2022
@kurkle
Copy link
Owner

kurkle commented Sep 18, 2022

@stockiNail about dataLabels, yes it would be best to rely on that plugin for the labels, it would avoid a lot of code.

@kurkle kurkle merged commit 200396b into kurkle:next Sep 18, 2022
@stockiNail
Copy link
Collaborator Author

@stockiNail about dataLabels, yes it would be best to rely on that plugin for the labels, it would avoid a lot of code.

I thought more on that. for Labels could be a good idea even if we couldn't address some enhancement (see #92). The caption could be manage by datalabels because needs to add space for that to the element and we need options that, going to datalabels, could be managed only by plugin. Therefore some login on labels for caption will remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add samples of usage with datalabels plugin
2 participants