-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable zoom plugin on treemap controller #141
Conversation
I set this as draft because I have forgotten to manage |
@kurkle do you think a sample is needed (importing zoom plugin)? And some tests (even if we didn't do for datalabels)? |
|
A sample would be ok. |
I'm still struggling with |
I think it would make things easier to move away from the |
Yes, t could be. But if you agree, I'd like to understand better how it works in CHART.JS (forgive my lack of knowledge on this internal parts of code) and probably this analysis will help me (at least me ;)) to understand better how to remove |
@kurkle if think I understood why I have issues with I think the final solution is to separate the data parsing and the element size calculation (planned for version 3). |
@kurkle Overriding |
Conflicts: src/controller.js
Ready for review. Sorry but the |
I think its so that for example points/lines are drawn on top of the drag area, but am not sure. |
Yes, I didn't add another comment but yes. Nevertheless for treemap, it's quite useless because the drag area is not visible (below the elements). I'd like to submit a PR to zoom plugin, adding |
Fix #140
Fix #139
codepen: https://codepen.io/stockinail/pen/bGMQRLN