Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend and correct Typescript Types #34

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Extend and correct Typescript Types #34

merged 2 commits into from
Jul 7, 2021

Conversation

allout58
Copy link
Contributor

  • Add types for TreemapController and TreemapElement
  • Fix types for TreemapControllerDatasetOptions
    • Did not match code or samples
  • Extend types for TreemapDataPoint
    • missing grouping keys

Resolves #33

@allout58
Extend and correct Typescript Types
9cd5e00 
- Add types for TreemapController and TreemapElement
- Fix types for TreemapControllerDatasetOptions
  - Did not match code or samples
- Extend types for TreemapDataPoint
  - missing grouping keys

Resolves kurkle#33
@kurkle
Copy link
Owner

kurkle commented Jul 5, 2021

[test-lint] /home/runner/work/chartjs-chart-treemap/chartjs-chart-treemap/types/index.esm.d.ts
[test-lint] 10:8 warning A space is required after '{' object-curly-spacing
[test-lint] 10:18 warning A space is required before '}' object-curly-spacing
[test-lint] 30:9 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
[test-lint] 74:23 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
[test-lint] 106:2 error Missing semicolon semi

@allout58
Copy link
Contributor Author

allout58 commented Jul 6, 2021

Didn't realize ESLint ran on this, will fix momentarily!

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@allout58 allout58 requested a review from kurkle July 6, 2021 15:39
@kurkle kurkle merged commit d40c4ff into kurkle:next Jul 7, 2021
@kurkle kurkle added the types label Jul 7, 2021
@allout58 allout58 deleted the feat.extend-fix-ts-types branch July 8, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle Awaiting requested review from kurkle

Assignees
No one assigned
Labels
types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript types do not include Controller and Element
2 participants
@allout58 @kurkle