サポートするPythonバージョンを「3.8以上」から「3.9以上」に変更しました。 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuji38kwmt
commented
Aug 2, 2024
| ], | ||
| // "poetry run"コマンドで実行することを想定しているので、venv環境を自動的にactivateしないようにする | ||
| "python.terminal.activateEnvironment":false, | ||
|
|
||
| "python.formatting.blackPath": ".venv/bin/black", |
There was a problem hiding this comment.
VSCode 1.91.1で警告が出るので削除しました。
yuji38kwmt
commented
Aug 2, 2024
| ], | ||
| "python.analysis.completeFunctionParens": true, | ||
| "[python]": { | ||
| "editor.formatOnSave": true, | ||
| "editor.codeActionsOnSave": { | ||
| "source.organizeImports": true | ||
| "source.organizeImports": "explicit" |
There was a problem hiding this comment.
VSCode 1.91.1の警告に従い修正しました。
yuji38kwmt
commented
Aug 2, 2024
| @@ -20,7 +20,7 @@ def open_resource(self) -> Generator[Resource, None, None]: | |||
| endpoint = ( | |||
| self._annofab_endpoint if self._annofab_endpoint is not None else annofabapi.resource.DEFAULT_ENDPOINT_URL | |||
| ) | |||
| resource = annofabapi.build(self._annofab_id, self._annofab_pass, endpoint) | |||
| resource = annofabapi.build(self._annofab_id, self._annofab_pass, endpoint_url=endpoint) | |||
There was a problem hiding this comment.
最新の annofabapi 0.74.0でエラーが出ないように修正しました。
yuji38kwmt
commented
Aug 2, 2024
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Topic :: Utilities", |
There was a problem hiding this comment.
poetry buildでPython関係のclassifiersは自動で生成されるので、削除しました。
https://qiita.com/yuji38kwmt/items/dbf6d20666c054d84e14
yuji38kwmt
commented
Aug 2, 2024
| @@ -7,7 +7,7 @@ | |||
|
|
|||
|
|
|||
| def camelcase(cls: Type[A]) -> Type[A]: | |||
| cls.dataclass_json_config = config(letter_case=LetterCase.CAMEL)["dataclasses_json"] # type: ignore | |||
| cls.dataclass_json_config = config(letter_case=LetterCase.CAMEL)["dataclasses_json"] # type: ignore[assignment] | |||
There was a problem hiding this comment.
mypy 1.11では、type: ignoreだけではエラーが出るので、ignore[assignment}と記載する
yuji38kwmt
commented
Aug 2, 2024
|
|
||
| install: | ||
| - pip install pip --upgrade | ||
| - pip install poetry==1.1.15 setuptools==50.3.2 |
There was a problem hiding this comment.
Poetryはsetupptolsは必須としていないので、削除しました。
https://python-poetry.org/docs/configuration#virtualenvsoptionsno-setuptools
Merged
seraphr
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode Dev Containers
Dockerfileの不要な設定（docker composeなど）を削除しました。devcontainer.jsonで不要な設定を削除しました。pyproject.tomlpyproject.toml: サポートするPythonバージョンを「3.8以上」から、「3.9以上」に変更しました。mypy,flake8,pylintのバージョンを最新にしました。flake8がPython3.12で動作しなかったためです。補足
先に #138 をマージしてから、このpull requestをマージします。