dataclasses-jsonとfireの許容するバージョンの範囲を広げました
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuji38kwmt
changed the title
dataclasses-jsonとfireの許容するバージョンを上げる
yuji38kwmt
commented
Aug 6, 2024
| @@ -7,7 +7,7 @@ | |||
|
|
|||
|
|
|||
| def camelcase(cls: Type[A]) -> Type[A]: | |||
| cls.dataclass_json_config = config(letter_case=LetterCase.CAMEL)["dataclasses_json"] # type: ignore[assignment] | |||
| cls.dataclass_json_config = config(letter_case=LetterCase.CAMEL)["dataclasses_json"] | |||
There was a problem hiding this comment.
dataclasses-jsonを最新バージョンにしたことで、mypyのエラーが出なくなったのでtype: ignoreコメントを削除しました。
yuji38kwmt
changed the title
dataclasses-jsonとfireの許容するバージョンを上げるdataclasses-jsonとfireの許容するバージョンの範囲を広げました
seraphr
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.tomlにdataclasses-json = "^0.5.7"と記載すると、「0.5.7以上、0.6未満」が利用可能なバージョンになります。annofab-3dpc-editor-cliに依存するPythonツールを開発する際、許容するバージョンの範囲が狭いと使いにくいので（たとえば、dataclasses-jsonの最新バージョンを使いたいのに使えない）ので、許容するバージョンの範囲を広げました。メジャーバージョンが
0の状態ならば、たぶん動作するだろうと考えてdataclasses-json= ">=0.5.7,<1"と記載しました。補足
動作確認したバージョンのみを許容するのであれば、
dataclasses-json= ">=0.5.7,<1"の方がよいかもしれません。