Fix double logger adding #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marek Materzok <tilk@tilk.eu>
|
You can't separate this change from #573? |
|
I can, but both edits the same part of code, so there will be conflict between them if this review will be based on master. |
|
This seems to be a straightforward change, and it also fixes a very annoying bug, so it could be merged very quickly. Meanwhile #573 has now around 500 lines of code and a number of features besides the main one (the CAM), so I expect that PR to be reviewed after some time. |
|
Ok, I will prepare a separate change, but this would be probably in Sunday. |
|
I have created a version which is based on master. Please see #694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved adding of our custom logger to "session" fixture, so there shouldn't be any more problems with duplicated logs. I tested it with command:
Resolves #675
Based on #573