Add support for "Monospace" control code (ASCII 0x11). #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthGandalf
approved these changes
Aug 1, 2024
Nope, outside of hacks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idling in some channels i received some message that our ircview was not able to cope with.
Turns out these messages contained ASCII 0x11, that's supposed to start a text section using monospace font.
https://modern.ircdocs.horse/formatting#monospace
I guess the idea is to replicate the
preformatted textused eg. by markdown or html's<pre>,<tt>,<code>tags.This PR add support for detecting this control code, so that the text get printed correctly, but by now the control code gets ignored.
Adding support for rendering different fonts in KviIrcView would require some heavy work and probably a few new options.