Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide possibility to use key ids #1289

Merged
merged 2 commits into from
May 17, 2019
Merged

Provide possibility to use key ids #1289

merged 2 commits into from
May 17, 2019

Conversation

DasJott
Copy link
Contributor

@DasJott DasJott commented Feb 22, 2019

JWT provides a possibility to use multiple secrets and specify the used one in its header field "kid".
Providing a map here to use that functionality.

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #1289 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
+ Coverage   84.18%   84.22%   +0.04%     
==========================================
  Files          26       26              
  Lines        1948     1953       +5     
==========================================
+ Hits         1640     1645       +5     
  Misses        202      202              
  Partials      106      106
Impacted Files Coverage Δ
middleware/jwt.go 80.72% <100%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be919e8...76ed13c. Read the comment docs.

@DasJott
Copy link
Contributor Author

DasJott commented Feb 28, 2019

@DasJott DasJott mentioned this pull request Mar 11, 2019
@stale
Copy link

stale bot commented Apr 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 29, 2019
@DasJott
Copy link
Contributor Author

DasJott commented Apr 29, 2019

Anyone?

@stale stale bot removed the wontfix label Apr 29, 2019
@vishr vishr merged commit e2671fe into labstack:master May 17, 2019
@vishr
Copy link
Member

vishr commented May 17, 2019

@DasJott Thanks for your contribution 👍and sorry about the delay.

@DasJott
Copy link
Contributor Author

DasJott commented May 17, 2019

You're welcome!
Very pleased to see it merged in 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants