Assign new ResponseWriter after calling http.HandlerFunc #1341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the
http.ResponseWriter
passed tonext()
within themiddleware is unused. This precludes middlewares from wrapping the
http.ResponseWriter to do things like record the status code.
Fixes #1257
There was a workaround mentioned in the linked issue to set the
echo.Response.Writer
in the middleware, but I think this is still an improvement as:rw
I passed tonext()
to get passed to the next middleware. In practice, I can just passnil
here and have the same effect asecho
doesn't capture and use therw