-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete unused context in body_limit.go #2483
Conversation
please run tests after changes and commit things that pass the tests. Currently this PR removes a field but one test still uses it. if you are using Linux, probably MacOS also - you can just run |
should I update the test file too? |
yes, tests need to be fixed as they fail after that change. As this PR is deleting that field - parts that require that field need to be changed in tests. |
Ok I amend my latest commit and push again |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
- Coverage 92.82% 92.81% -0.01%
==========================================
Files 39 39
Lines 4624 4623 -1
==========================================
- Hits 4292 4291 -1
Misses 241 241
Partials 91 91
☔ View full report in Codecov by Sentry. |
according to this issue, I remove unused context in limitedReader struct