Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add comments to util.go randomString #2494

Merged
merged 3 commits into from
Jul 22, 2023
Merged

docs: add comments to util.go randomString #2494

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
982dbc9
Update util.go
trim21 Jul 22, 2023
0014874
update
trim21 Jul 22, 2023
b12202c
update
trim21 Jul 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions middleware/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ func randomString(length uint8) string {
r := make([]byte, length+(length/4)) // perf: avoid read from rand.Reader many times
var i uint8 = 0

// security note:
// we can't just simply do b[i]=randomStringCharset[rb%len(randomStringCharset)],
// len(len(randomStringCharset)) is 52, and rb is [0, 255], 256 = 52 * 4 + 48.
// make the first 48 characters more possibly to be generated then others.
// So we have to skip bytes when rb > randomStringMaxByte

for {
_, err := io.ReadFull(reader, r)
if err != nil {
Expand Down