Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of linear model fitting failure #187

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

jmuhlich
Copy link
Collaborator

@jmuhlich jmuhlich commented Apr 7, 2023

Now we look at the determinant of the matrix of coefficients, not just whether all the individual values are zero. Also the intercept is now zeroed out which fixes the single tile placed far from the rest (even though this was a sign of complete EdgeAligner failure). A warning is emitted in the failure case to alert the user of the problem.

Now we look at the determinant of the matrix of coefficients, not just
whether all the individual values are zero. Also the intercept is now
zeroed out which fixes the single tile placed far from the rest
(even though this was a sign of complete EdgeAligner failure). A
warning is emitted in the failure case to alert the user of the problem.
@jmuhlich jmuhlich merged commit 0176ba5 into labsyspharm:master Apr 7, 2023
@jmuhlich jmuhlich deleted the linear-model-fail branch April 7, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant