Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with util._extend deprecation in @ladjs/consolidate #4

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

banoni-dev
Copy link

@banoni-dev banoni-dev commented Jul 10, 2024

Description

This PR addresses the deprecation warning related to the use of util._extend() in the @ladjs/consolidate package. The warning is as follows:

(node:72911) [DEP0060] DeprecationWarning: The util._extend API is deprecated. Please use Object.assign() instead.

Issue

The util._extend API is deprecated and has been exposed to the user land by accident. This API is no longer maintained and should be replaced with Object.assign() as per the Node.js documentation: Node.js Deprecation Warnings

This issue is particularly problematic when using Node.js version 22, where the warning is prominently displayed, causing potential confusion and clutter in the logs.

Changes Made

  • Replaced all instances of util._extend() with Object.assign() in the codebase.
  • Ensured that the new implementation is consistent with the previous functionality.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism titanism merged commit 3a43539 into ladjs:master Jul 10, 2024
2 checks passed
@titanism
Copy link

Thank you @banoni-dev 🙏

Published in v1.0.4 to npm under @ladjs/consolidate and consolidate

https://github.com/ladjs/consolidate/releases/tag/v1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants