Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat cxx 11 min standard #1267

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Conversation

fspindle
Copy link
Contributor

  • Bump cxx11 as minimum standard
  • Use nullptr instead of NULL
  • Fix build around cv::canny usage when OpenCV < 3.2.0
  • Fix build of vpCircleHoughTransform when nlohmann json not available

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 193 lines in your changes are missing coverage. Please review.

Comparison is base (549fb2c) 54.38% compared to head (daaf054) 54.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   54.38%   54.38%   -0.01%     
==========================================
  Files         400      400              
  Lines       50484    50486       +2     
==========================================
  Hits        27456    27456              
- Misses      23028    23030       +2     
Files Coverage Δ
...dules/core/include/visp3/core/vpCameraParameters.h 100.00% <ø> (ø)
modules/core/include/visp3/core/vpColVector.h 79.16% <100.00%> (ø)
modules/core/include/visp3/core/vpDebug.h 0.00% <ø> (ø)
modules/core/include/visp3/core/vpException.h 100.00% <ø> (ø)
...ules/core/include/visp3/core/vpHomogeneousMatrix.h 100.00% <ø> (ø)
modules/core/include/visp3/core/vpImage.h 82.53% <100.00%> (ø)
modules/core/include/visp3/core/vpImageConvert.h 93.33% <ø> (ø)
modules/core/include/visp3/core/vpImagePoint.h 100.00% <100.00%> (ø)
modules/core/include/visp3/core/vpImageTools.h 87.66% <100.00%> (ø)
modules/core/include/visp3/core/vpLinProg.h 100.00% <ø> (ø)
... and 78 more

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit fa84fee into lagadic:master Oct 28, 2023
53 checks passed
@fspindle fspindle deleted the feat_cxx_11_min_standard branch July 3, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant