Fix issue with connection not released in specific scenario #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Sep 20, 2023
Ocramius
reviewed
Sep 20, 2023
…atement when in prepare mode Signed-off-by: Ionut Codreanu <ionut@f6s.com>
…r\Adapter Signed-off-by: Ionut Codreanu <ionut@f6s.com>
…rk it as deprecated Signed-off-by: Ionut Codreanu <ionut@f6s.com>
Xerkus
force-pushed
the
database_connection_not_released
branch
from
5f43b63
to
e725a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use local variable instead of instance variable for storing select statement when in prepare mode
Description
Found the issue while running integration tests using the database adapter. If in the same method you fetch something from database using
\Laminas\Db\Adapter\Adapter::queryin prepare mode and after use the table gateway to fetch something from the database, a reference to the PDO connection remains and is not released when trying to disconnect from the database.Added a test case with the scenario with many tests in the data provider. On the tearDown I have disconnected from the database.