-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for PHP 8.0, Remove hard dependency on service manager #76
Remove support for PHP 8.0, Remove hard dependency on service manager #76
Conversation
…ict consumers to psr/container:1.0 Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Ughh - we have to drop PHP 8.0 and work around the BC break in tests introduced in SM 3.21 |
…inimum and fix pluginmanager compatibility tests Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel @MegaChriz |
Thanks for picking this up so quickly! On my local install I have PHP 8.1 and that looked to go well. I saw that on a I hope to test with PHP 8.2 soon! |
Feeds does indeed use These are other classes/interfaces that Feeds uses:
|
This just needs an approving review from someone on the @laminas/technical-steering-committee and it can be released |
Feeds tests pass Feeds can now be installed using composer
With that I could require drupal/feeds with success! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gsteel!
Further to discussion in #75, removing the hard-dependency on laminas/service-manager here allows consumers to use the component in projects that require
psr/container:2
, providing they only use theStandaloneExtensionManager
forReader\
andWriter\