Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESX(i) 7.0.3 #249

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Add support for ESX(i) 7.0.3 #249

merged 3 commits into from
Oct 20, 2021

Conversation

pmhausen
Copy link
Contributor

No description provided.

@lamw lamw merged commit c8f620d into lamw:master Oct 20, 2021
@pmhausen
Copy link
Contributor Author

Thanks for accepting. Would you be so kind to add "hacktoberfest" as a topic to the project for the rest of October?

@stickybyte
Copy link

@lamw seting the topic as @pmhausen requested would be fine. Then my closed request will be counted too...

@lamw lamw changed the title Add support for ESX(i) 7.0.3 **hacktoberfest-accepted** Add support for ESX(i) 7.0.3 Oct 20, 2021
@p-schneider
Copy link
Contributor

p-schneider commented Oct 21, 2021

@lamw I just realized the LAST_MODIFIED_DATE constant was not changed for the 2021_10_20 release
running
grep ^LAST_MODIFIED_DATE /opt/ghettovcb/bin/ghettoVCB.sh
still gives me
LAST_MODIFIED_DATE=2021_07_09
(Running grep VER=7 /opt/ghettovcb/bin/ghettoVCB.sh shows me I'm on the version with the latest changes.)

@lamw
Copy link
Owner

lamw commented Oct 21, 2021

@p-schneider Can you file a quick issue and that way someone can take it?

@p-schneider
Copy link
Contributor

PR created at #250 (or did you mean issue like in "Issues" != "Pull Requests"?)

@pmhausen
Copy link
Contributor Author

pmhausen commented Oct 21, 2021 via email

@lamw
Copy link
Owner

lamw commented Oct 21, 2021

@p-schneider Yea, typically (I only recently learned about this while working on another OSS project) that you'd normally file an Issues which explains the problem or feature. Then you'll open up a PR which then closes an existing Issue, which is useful for tracking purposes.

I'll review shortly and rebuild the deliverables, thanks again!

@lamw
Copy link
Owner

lamw commented Oct 21, 2021

Hi William, while you are at it, could you please remove the hacktoberfest-accepted from the commit message (unless you don't mind it being there) and add a label or a topic as shown in the two tweets I retweeted to you? That would be awesome, Patrick -- punkt.de GmbH Patrick M. Hausen .infrastructure Kaiserallee 13a 76133 Karlsruhe Tel. +49 721 9109500 https://infrastructure.punkt.de @.*** AG Mannheim 108285 Geschäftsführer: Jürgen Egeling, Daniel Lienert, Fabian Stein

You mean from the PR title? Its not in the commit message since that's something that happens on your end when you create the PR

@lamw lamw changed the title **hacktoberfest-accepted** Add support for ESX(i) 7.0.3 Add support for ESX(i) 7.0.3 Oct 21, 2021
@pmhausen
Copy link
Contributor Author

pmhausen commented Oct 21, 2021 via email

@lamw
Copy link
Owner

lamw commented Oct 21, 2021

Sorry, I don't see what you're referring to. Might be best to ask folks on explicitly what is needed to qualify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants