-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Azure Search Vector Store is missing Access Token Authentication #24330
community: Azure Search Vector Store is missing Access Token Authentication #24330
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
can someone take a look at this, I cant remove the new dependency azure.identiy |
I am tagging some contributors to this file as I need some help to continue:
I tried to fix it but I get errors with the depency, if I add the dependency using Poetry, then the dependecy check fails, if I dont, then I get different errors. Your help is greatly appreciated. |
https://python.langchain.com/v0.2/docs/contributing/code/setup/#working-with-optional-dependencies |
extended_testing_deps.txt already has the azure-identity
I added azure-core to extended_testing_deps.txt, azure-identity was already there.
However I have this error:
that can be solved using poetry add, but if I do then I get a test dependency error, because it should be optional. or shouldnt I use poetry add? |
…ncia/langchain into AzureSearchVectorDatabase
… None. otherwise unreachable code detected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattgotteiner canb you approve?
@baskaryan can you merge or something else is needed? |
@baskaryan I have tried all communication channels for this PR to be approved, in the meantime changes have happened on the community repo and several versions have been released, almost 30 days waiting time seems a lot, or maybe I am reaching the wrong person? |
…ncia/langchain into AzureSearchVectorDatabase
Hey @levalencia ! Sorry for the delay. You did nothing wrong, and we're working on publishing better expectations for getting community PRs reviewed and how to escalate issues, based on VSCode's issue triaging. Thank you for your contribution! |
Added Azure Search Access Token Authentication instead of API KEY auth.
Fixes Issue: #24263
Dependencies: None
Twitter: @levalencia
@baskaryan
Could you please review? First time creating a PR that fixes some code.