Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(community): update to OpenLLM 0.6 #24609

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Jul 24, 2024

Update to OpenLLM 0.6, which we decides to make use of OpenLLM's OpenAI-compatible endpoint. Thus, OpenLLM will now just become a thin wrapper around OpenAI wrapper.

Signed-off-by: Aaron Pham contact@aarnphm.xyz

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 24, 2024
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 2:44am

@aarnphm aarnphm changed the title breaking: update to OpenLLM 0.6 chore(community): update to OpenLLM 0.6 Jul 24, 2024
@dosubot dosubot bot added the community Related to langchain-community label Jul 24, 2024
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update the integration tests instead of removing them?

or even implement the standard integration tests. see example https://github.com/langchain-ai/langchain/blob/master/libs/partners/openai/tests/integration_tests/chat_models/test_base_standard.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do


class OpenLLM(BaseOpenAI):
"""OpenAI's compatible API client for OpenLLM server"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a note to the docstring, something like

.. versionchanged:: 0.2.11

  Changed in 0.2.11 to support OpenLLM 0.6. Requires ...

@baskaryan baskaryan added the needs test PR needs to be updated with tests label Jul 26, 2024
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm
Copy link
Contributor Author

aarnphm commented Aug 7, 2024

Hi @baskaryan I have added the tests PTAL thanks.

@aarnphm
Copy link
Contributor Author

aarnphm commented Sep 16, 2024

bump @baskaryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community needs test PR needs to be updated with tests size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Needs support
Development

Successfully merging this pull request may close these issues.

2 participants