Do not mutate underlying values on redirect (#46281)

laravel · Feb 27, 2023 · 5e8f9b0 · 5e8f9b0
1 parent 864d2e5
commit 5e8f9b0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Illuminate/Routing/RedirectController.php b/src/Illuminate/Routing/RedirectController.php
@@ -31,7 +31,7 @@ public function __invoke(Request $request, UrlGenerator $url)
 
         $parameters = $parameters->only(
             $route->getCompiled()->getPathVariables()
-        )->toArray();
+        )->all();
 
         $url = $url->toRoute($route, $parameters, false);
 

diff --git a/tests/Integration/Routing/RouteRedirectTest.php b/tests/Integration/Routing/RouteRedirectTest.php
@@ -2,6 +2,8 @@
 
 namespace Illuminate\Tests\Integration\Routing;
 
+use Illuminate\Foundation\Auth\User;
+use Illuminate\Routing\Middleware\SubstituteBindings;
 use Illuminate\Support\Facades\Route;
 use Orchestra\Testbench\TestCase;
 
@@ -35,6 +37,19 @@ public static function routeRedirectDataSets()
         ];
     }
 
+    public function testRouteRedirectWithExplicitRouteModelBinding()
+    {
+        $this->withoutExceptionHandling();
+        Route::middleware([SubstituteBindings::class])->group(function () {
+            Route::redirect('users/{user}', 'users/{user}/overview');
+        });
+        Route::bind('user', fn ($id) => (new User())->setAttribute('id', '999'));
+
+        $response = $this->get('users/1');
+
+        $response->assertRedirect('users/999/overview');
+    }
+
     public function testToRouteHelper()
     {
         Route::get('to', function () {